onlineddl_vrepl suite: fix auto_increment flakyness #12246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a recurring CI error with
onlineddl_vrepl_suite
(not to be confused with another flakyness we have inonlineddl_vrepl
). The flakyness fixed here has to do withAUTO_INCREMENT
values, and which depends on the MySQL version. I simplified the tests by just saying something like "here's a starting point atauto_increment=8
, gonna throw a bunch of stuff at the table, delete or whatnot, and expect resultingauto_increment
to be two digit. That's it. Previously, we tried to hit the exact resulting value. But the value does not matter. What matters is that e.g. when rows are deleted, and table is duplicated, we don't fall back toauto_increment=8
.Related Issue(s)
#6926
Checklist
Deployment Notes