Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ESM is always strict mode #9454

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Conversation

sapphi-red
Copy link
Member

Description

Vite cannot support codes that only runs in non-strict mode. I think this limitation should be documented somewhere.

close #9430
refs #8889

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Jul 30, 2022
@patak-dev patak-dev merged commit 46264ff into vitejs:main Jul 30, 2022
@sapphi-red sapphi-red deleted the docs/strict-mode branch July 30, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot create property 'lineStyle' on boolean 'false'
3 participants