Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add overflow to Vite CLI code block #9390

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Evavic44
Copy link
Contributor

Description

Add overflow-x: auto to the Vite CLI code block in the Vite 3.0 announcement page. This adds a horizontal scrollbar for viewers on mobile screens: (375 x 667) to be precise.

Reference Issue: #9383

Additional context

The property was added directly into the <pre> element found here. Not completely sure if that's the recommended way of doing it. I'm happy to take any corrections.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Thanks @Evavic44!

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Jul 27, 2022
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sapphi-red sapphi-red changed the title docs: Add overflow to Vite CLI code block docs: add overflow to Vite CLI code block Jul 27, 2022
@sapphi-red sapphi-red merged commit c78e409 into vitejs:main Jul 27, 2022
@Evavic44 Evavic44 deleted the docs-blog-fix branch August 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants