Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: show ws port conflict error #8209

Merged
merged 2 commits into from
May 18, 2022
Merged

chore: show ws port conflict error #8209

merged 2 commits into from
May 18, 2022
+6 −1

Conversation

sapphi-red
Copy link
Member

Description

Show error when ws port conflicts.
Reproduction is written in #8197.

refs #8197

Additional context

There might be a reason?
c6bb3e4#diff-7ea20ab586e000d69e1adb4aeb7e126745c763f6d15f30e09f8ca2149722e6f1R27-R32

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 18, 2022
@patak-dev patak-dev merged commit c86329b into vitejs:main May 18, 2022
@sapphi-red sapphi-red deleted the chore/ws-port-conflict-error branch May 18, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev