Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .eslintignore #7769

Closed
wants to merge 1 commit into from
Closed

chore: add .eslintignore #7769

wants to merge 1 commit into from

Conversation

dammy001
Copy link

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently run eslint packages/*/{src,types}/** for linting, and it doesn't touch any of the ignored files listed in this PR's .eslintignore. Is there a reason to add one?

@Shinigami92
Copy link
Member

We currently run eslint packages/*/{src,types}/** for linting, and it doesn't touch any of the ignored files listed in this PR's .eslintignore. Is there a reason to add one?

@bluwy I assume it can be useful when using the VSCode extension.
Your mentioned line is only run on demand, but the VSCode extension performs on any file that is not ignored.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Apr 19, 2022
@sapphi-red sapphi-red mentioned this pull request Jul 31, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants