Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): css.devSourcemap option #7471

Merged
merged 3 commits into from
Mar 26, 2022
Merged

feat(css): css.devSourcemap option #7471

merged 3 commits into from
Mar 26, 2022

Conversation

sapphi-red
Copy link
Member

Description

Add css.devSourcemap option to make users to opt in.

#7173

Additional context

Not sure if it is a feature. Maybe other?

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red force-pushed the feat/css-dev-sourcemap-option branch from 8d45ef2 to 65607c5 Compare March 26, 2022 12:43
patak-dev
patak-dev previously approved these changes Mar 26, 2022
View reviewed changes
antfu
antfu previously approved these changes Mar 26, 2022
View reviewed changes
poyoho
poyoho reviewed Mar 26, 2022
View reviewed changes
Copy link
Member

@poyoho poyoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! Some picky suggestions. 😄

packages/vite/src/node/plugins/css.ts Show resolved Hide resolved
packages/vite/src/node/plugins/css.ts Show resolved Hide resolved
packages/plugin-vue/src/index.ts Show resolved Hide resolved
@patak-dev patak-dev dismissed stale reviews from antfu and themself via 787fad1 March 26, 2022 14:47
@patak-dev patak-dev merged commit 57f14cb into vitejs:main Mar 26, 2022
@ydcjeff
Copy link
Contributor

ydcjeff commented Mar 26, 2022

Sorry for the late review. Should this option be added to the docs?

@sapphi-red sapphi-red deleted the feat/css-dev-sourcemap-option branch March 26, 2022 16:12
@sapphi-red sapphi-red mentioned this pull request Mar 26, 2022
Merged
9 tasks
@bluwy bluwy mentioned this pull request Apr 8, 2022
Closed
4 tasks
@patak-dev
Copy link
Member

For reference, we're gathering feedback about this feature to move it out of experimental in this discussion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyoho poyoho poyoho approved these changes

@patak-dev patak-dev patak-dev approved these changes

@antfu antfu antfu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sapphi-red @ydcjeff @patak-dev @antfu @poyoho