Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(less): empty less file error #7412

Merged
merged 3 commits into from
Mar 23, 2022
Merged

fix(less): empty less file error #7412

merged 3 commits into from
Mar 23, 2022

Conversation

tyouzu1
Copy link
Contributor

@tyouzu1 tyouzu1 commented Mar 23, 2022 •
edited
Loading

fix : read the less file if it is an empty file, will throw an error
#7411

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@tyouzu1 tyouzu1 mentioned this pull request Mar 23, 2022
Merged
9 tasks
@tyouzu1 tyouzu1 mentioned this pull request Mar 23, 2022
Closed
7 tasks
@tyouzu1 tyouzu1 changed the title fix: empty less file error fix(less): empty less file error Mar 23, 2022
@tyouzu1 @patak-dev
fix: update code style
b1a61a9 
Co-authored-by: patak <matias.capeletto@gmail.com>
sapphi-red
sapphi-red approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@patak-dev patak-dev merged commit 0535c70 into vitejs:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyouzu1 @patak-dev @sapphi-red