Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate rollupOptions.output.output to avoid subtle errors #5930

Merged
merged 2 commits into from
Dec 2, 2021
Merged

chore: deprecate rollupOptions.output.output to avoid subtle errors #5930

merged 2 commits into from
Dec 2, 2021

Conversation

haoqunjiang
Copy link
Member

Description

As explained in #5812 (comment)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Dec 2, 2021
View reviewed changes
@Shinigami92
Copy link
Member

Prettier complains something about wrong formatting, pls run prettier

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Dec 2, 2021
@patak-dev patak-dev merged commit e3a1aa5 into vitejs:main Dec 2, 2021
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 1, 2022
@sapphi-red
chore: reapply vitejs#5930
6c2cbc9
@sapphi-red sapphi-red mentioned this pull request Jun 1, 2022
Merged
9 tasks
patak-dev pushed a commit that referenced this pull request Jun 1, 2022
@sapphi-red
chore: reapply #5930 (#8423)
ab23e6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@bluwy bluwy bluwy left review comments

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoqunjiang @Shinigami92 @patak-dev @bluwy