-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: isBuiltin
using patched native builtinModules
#5827
Conversation
… `node:` support
|
looks like some node 12 tests expect |
I'm also not sure that what I said here isn't an issue: #5827 (comment). For the beta, maybe we could go with the full harcoded list (or compute it by patching const builtins = new Set([
...builtinModules,
'fs/promises',
// and others...
]) Later we can research with more time if it is safe to only use |
Yeah, the safe option, for now, is to use a hard-coded list + We can revisit it later in 2.8 or 3.0 to see if the edge case that "compiling using node v12 code to be run in node v16 in the server" is what we intend to support. |
For reference, it looks like |
Co-authored-by: Shinigami <chrissi92@hotmail.de>
builtinModules
array with added valid import syntaxes isBuiltin
using patched native builtinModules
hello 我是伟龙。已收到您的邮件,这是来自QQ邮箱的假期自动回复邮件,请勿回复。
|
Description
fix: #5826
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).