Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin-vue dev scripts error in ssr-vue #5607

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

zhangyuang
Copy link
Contributor

@zhangyuang zhangyuang commented Nov 10, 2021

Description

In packages/plugin-vue which use tsc transform ts=>js in development and use esbuild compile all dependencies as one file.

Because https://unpkg.com/browse/slash@4.0.0/index.js only export esmodule file which cause require("slash") error in some file convert from tsc in ssr-vue playground.

So, i change plugin-vue dev scripts to use esbuild --watch and tsc parallelly
image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@zhangyuang
Copy link
Contributor Author

cc @sodatea @Shinigami92 @antfu

@zhangyuang
Copy link
Contributor Author

@patak-js can review it?

@patak-dev patak-dev merged commit 502b8f2 into vitejs:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants