fix: normalize away base in imported URLs
#5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes hot-reloading issues reported in vitejs#5063.
|
Could we add a test case to avoid this regression in the future? |
I'd love to, I'm just not sure how to reproduce with a simple codebase 😬 |
|
Oh, sorry didn't see the explanation in the issue. We'll ask Evan today about this 👍🏼 |
patak-dev
added
the
p3-minor-bug
yyx990803
approved these changes
Sep 24, 2021
|
Thank you both! 🚀 |
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
* fix: normalize away `base` in imported URLs This fixes hot-reloading issues reported in vitejs#5063. * Update importAnalysis.ts Co-authored-by: Evan You <yyx990803@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes hot-reloading issues reported in #5063.
This code was removed in https://github.com/vitejs/vite/pull/5037/files, presumably by accident, but perhaps on purpose.
Additional context
I'm not familiar enough with
importAnalysisto figure out whether this is also needed forstaticImportedUrls.I'm also not sure how to test this, so someone else feel free to take over :)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).