Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a workaround to isolatedModules: true #4286

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

fwouts
Copy link
Contributor

@fwouts fwouts commented Jul 17, 2021

Description

I recently published a Rollup plugin designed for TypeScript projects that aren't ready to transition to isolatedModules: true (this is used in React Preview, for example). This PR points to it from the documentation, in the hope that it will help projects move to Vite more easily.

Feel free to close this PR—I'd understand if we prefer not to point to barely known third-party plugins from the official docs!

Additional context

See evanw/esbuild#1398 for some prior discussion about integrating this directly into esbuild.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Jul 17, 2021
@hyf0
Copy link
Contributor

hyf0 commented Oct 21, 2021

Great guidance. It's very of help for migrating some old and big history ts project.

@patak-dev patak-dev merged commit ea0c221 into vitejs:main Oct 21, 2021
@fwouts fwouts deleted the patch-1 branch April 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants