Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid builtStart during vite optimize #19356

Merged
merged 1 commit into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/node/idResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ export function createIdResolver(
idOnly: true,
}),
],
undefined,
false,
)
pluginContainerMap.set(environment, pluginContainer)
}
Expand All @@ -92,6 +94,8 @@ export function createIdResolver(
pluginContainer = await createEnvironmentPluginContainer(
environment as Environment,
[aliasPlugin({ entries: environment.config.resolve.alias })],
undefined,
false,
)
aliasOnlyPluginContainerMap.set(environment, pluginContainer)
}
Expand Down
2 changes: 2 additions & 0 deletions packages/vite/src/node/optimizer/scan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ export class ScanEnvironment extends BaseEnvironment {
this._pluginContainer = await createEnvironmentPluginContainer(
this,
this.plugins,
undefined,
false,
)
}
}
Expand Down
4 changes: 4 additions & 0 deletions packages/vite/src/node/server/pluginContainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,13 @@ export async function createEnvironmentPluginContainer(
environment: Environment,
plugins: Plugin[],
watcher?: FSWatcher,
autoStart = true,
): Promise<EnvironmentPluginContainer> {
const container = new EnvironmentPluginContainer(
environment,
plugins,
watcher,
autoStart,
)
await container.resolveRollupOptions()
return container
Expand Down Expand Up @@ -183,7 +185,9 @@ class EnvironmentPluginContainer {
public environment: Environment,
public plugins: Plugin[],
public watcher?: FSWatcher,
autoStart = true,
) {
this._started = !autoStart
this.minimalContext = new MinimalPluginContext(
{ rollupVersion, watchMode: true },
environment,
Expand Down