Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow expanding env vars in reverse order #19352

Conversation

sapphi-red
Copy link
Member

Description

Reverts the breaking change caused by dotenv-expand v12 upgrade by patching it.

fixes #18975

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 4, 2025
docs/guide/migration.md Outdated Show resolved Hide resolved
Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>
@patak-dev
Copy link
Member

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Feb 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite@19352

commit: d2afe9c

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on d2afe9c: Open

suite result latest scheduled
astro failure failure
histoire failure failure
ladle failure failure
nuxt failure success
previewjs failure failure
qwik failure failure
redwoodjs failure failure
vitest failure failure
waku failure failure

analogjs, laravel, marko, quasar, rakkas, react-router, storybook, sveltekit, unocss, vike, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt is failing due to the corepack issue. Let's merge and release a new patch today.

@patak-dev patak-dev merged commit 3f5f2bd into vitejs:main Feb 4, 2025
17 checks passed
@sapphi-red sapphi-red deleted the fix/allow-expanding-env-vars-in-reverse-order branch February 5, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) trigger: preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in .env variable expansion when loading additional files
2 participants