fix(server): recover server.ws.clients.send API changes for back compatibility

[antfu]

During refactoring of Environment API, I think we mistakenly change the send signature on WebSocketClient, causing a breaking regression:

Vite 5:

vite/packages/vite/src/node/server/ws.ts

Lines 65 to 72 in 81e6c04

	/**
	* Send event to the client
	*/
	send(payload: HMRPayload): void
	/**
	* Send custom event
	*/
	send(event: string, payload?: CustomPayload['data']): void

Vite v6.0.0 (WebSocketClient extends HotChannelClient):

vite/packages/vite/src/node/server/hmr.ts

Lines 78 to 80 in c7b3308

	export interface HotChannelClient {
	send(payload: HotPayload): void
	}

[sheremet-va]

I am not sure this was done by mistake, the payload in channels should now be always normalized 🤔

[sheremet-va]

The PR that changes how hot channels work: #18362

I think one of the goals was to make it easier to work from the outside to remove the if - maybe it is not wrapped by mistake?

[antfu]

Ah I see. I get the clients by for (const client of server.ws.clients) which seems to be a public API.

[sapphi-red]

I didn't expect to break things on server.ws and I think we can keep this compat. I pushed a commit that fixes the type (The Client should not extend HotChannel).

[antfu]

Thanks! Indeed, that makes more sense! This PR doesn't seems to fully solve my case on vite-plugin-inspect yet, I will keep investigating and send other PRs if any

[antfu]

After some digging, I found the problem is that in that in vite-dev-rpc:

https://github.com/antfu/vite-dev-rpc/blob/b6899623ed19297e5927262396f0d4bfdc34016b/src/index.ts#L18-L28

L27 uses server.ws.clients.send with two args API, which this PR fixes.

While L22 compared the matched source with the new branch, the hot client always gets normalized; thus, the instances are different. And during the normalization, source.socket gets lost as undefined

vite/packages/vite/src/node/server/hmr.ts

Lines 233 to 254 in e26acf4

	const listenerWithNormalizedClient = (
	data: any,
	client: HotChannelClient,
	) => {
	const normalizedClient: NormalizedHotChannelClient = {
	send: (...args) => {
	let payload: HotPayload
	if (typeof args[0] === 'string') {
	payload = {
	type: 'custom',
	event: args[0],
	data: args[1],
	}
	} else {
	payload = args[0]
	}
	client.send(payload)
	},
	}
	fn(data, normalizedClient)
	}
	normalizedListenerMap.set(fn, listenerWithNormalizedClient)

I will come up with an alternative PR to propose the fix

[antfu]

Raised #18781

[patak-dev]

Closing as #18782 has been merged