Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reporter using custom per env api #17297

Merged

Conversation

patak-dev
Copy link
Member

Description

Testing createWeakData patterns. With this one, it may be better to rename it to usePerEnvironmentState or similar.

Copy link

stackblitz bot commented May 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

antfu

This comment was marked as duplicate.

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the refactoring that make things much more scoped as well!

@patak-dev patak-dev merged commit c43c987 into v6/environment-api May 24, 2024
12 of 13 checks passed
@patak-dev patak-dev deleted the feat/reporter-refactor-using-custom-per-env-api branch May 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants