Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime): seal ES module namespace object instead of feezing #15914

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 14, 2024

Description

According to MDN ES modules are actually sealed and not frozen. This doesn't make any difference in the Vite case because we define getters so redefining properties always throws an error anyway.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va sheremet-va added the feat: environment API Vite Environment API label Feb 14, 2024
@sheremet-va sheremet-va changed the title fix(runtime): seal ES module namespace object instead of feezing refactor(runtime): seal ES module namespace object instead of feezing Feb 14, 2024
@sheremet-va sheremet-va added the p1-chore Doesn't change code behavior (priority) label Feb 14, 2024
@patak-dev patak-dev merged commit 4172f02 into vitejs:main Feb 14, 2024
14 checks passed
@sheremet-va sheremet-va deleted the fix/runtime-seal branch February 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants