fix(hmr): make watcher ignore build.outDir #15326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
added
the
p2-nice-to-have
|
Thanks for the PR @nozomuikuta! I'll add this one to the team board for discussion. If we merge it, we will be doing it as part of the next minor (we may take a few weeks to answer because of the holiday season). |
bluwy
previously approved these changes
Dec 20, 2023
patak-dev
previously approved these changes
Jan 8, 2024
|
Thank you for approving the PR! I found this PR came to conflict with the latest By the way, is it fine to close #15326 (comment) without applying the change? |
|
@nozomuikuta I think you should commit your proposed change at https://github.com/vitejs/vite/pull/15326/files#r1434206818 👍🏼 |
|
Committed it and resolved the conversation! 🚀 |
bluwy
approved these changes
Jan 9, 2024
patak-dev
approved these changes
Jan 9, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #15241
I just added
build.outDirto Chokidar'signoredoption.Additional context
This is my very first PR to Vite, so I might be missing something important.
Please be careful.
What is the purpose of this pull request?
I guess watching
build.outDiris unexpected, so it's a bug.Before submitting the PR, please make sure you do the following
fixes #123).I'm not sure how to unit-test this PR.
I confirmed that this PR resolves the original issue by following reproduction steps of it.