Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump minimum node version to 18 #14030

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat!: bump minimum node version to 18 #14030

merged 1 commit into from
Aug 15, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 6, 2023

Description

Bump the packages in this monorepo to require minimum node 18. Not sure if we need to bump to a specific minor version of 18, currently have it at 18.0.0

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added breaking change p3-significant High priority enhancement (priority) labels Aug 6, 2023
@bluwy bluwy added this to the 5.0 milestone Aug 6, 2023
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Aug 7, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ✅ success
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@patak-dev
Copy link
Member

Let's wait a bit with this one, asking for feedback about when WebContainers will move to Node 18. I tried codeflow and it works apart from a few warnings so we could also merge it before we release the first alpha/beta.

@sapphi-red sapphi-red mentioned this pull request Aug 10, 2023
9 tasks
@sapphi-red
Copy link
Member

If we bump to 18.4.0, we can simplify this part.

(detail.family === 'IPv4' ||
// @ts-expect-error Node 18.0 - 18.3 returns number
detail.family === 4),

(Because it will include nodejs/node#43054)
That said, I think it's fine going with 18.0.0 as this is a tiny one.

@patak-dev
Copy link
Member

The version in StackBlitz should be updated after Node 16 EOL, let's move forward with this one. It stills works, there is only a warning.

I already removed node-14 and node-16 from the test matrix.

@patak-dev patak-dev merged commit 2c1a45c into main Aug 15, 2023
10 checks passed
@patak-dev patak-dev deleted the node18 branch August 15, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants