-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): spread lightningcss options #14024
Conversation
|
Oh yeah my bad I totally forgot the add the spread at the end. That's nice that TS fails very locally on the lightningCSS types reference, I need to test this on my side but like the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finally decided to not spread on transformStyleAttribute
.
This is used very rarely and I think it will cause more bugs in the future that will solve usecases.
Thanks for this simplification of the build!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! And thanks for spotting this improvement.
This reverts commit 63a4451.
Description
Before this PR
lightning.d.ts
had a comment saying:But, in the actual implementation the options weren't spread; so you couldn't use
visitor
& other non-exposed features.Furthermore, I also exposed all LightingCSS options in the types, without impacting bundle size, by not bundling LightingCSS.
This means, if you don't have
lightingcss
installed,LightningCSSOptions
resolves toany
, but otherwise you get the full types.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).