Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed errors that appear after installing template-react-ts #13547

Closed
wants to merge 3 commits into from
Closed

fix: fixed errors that appear after installing template-react-ts #13547

wants to merge 3 commits into from

Conversation

rick-schultz
Copy link

@rick-schultz rick-schultz commented Jun 17, 2023

Description

Fixed [Error: cannot find module vite, react, react-router-dom]
Fixed [Error: 'module' is not defined.eslint]

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@rick-schultz rick-schultz changed the title fixed error that appears after installing unsing template-react-ts fix: fixed error that appears after installing unsing template-react-ts Jun 17, 2023
@rick-schultz rick-schultz changed the title fix: fixed error that appears after installing unsing template-react-ts fix: fixed error that appears after installing template-react-ts Jun 17, 2023
@rick-schultz rick-schultz changed the title fix: fixed error that appears after installing template-react-ts fix: fixed errors that appear after installing template-react-ts Jun 17, 2023
@ArnaudBarre
Copy link
Member

Hi,
The bundler error is due to an outdated VS Code version (and I hope it will be fixed on Stackblitz soon) cc @patak-dev

For the eslint error, I would prefer to not enable the node env on all the codebase, #13517 seems a better fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants