fix: avoid builtStart during vite optimize (#19356)

vitejs · Feb 5, 2025 · fdb36e0 · fdb36e0
1 parent cf10b41
commit fdb36e0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/packages/vite/src/node/idResolver.ts b/packages/vite/src/node/idResolver.ts
@@ -72,6 +72,8 @@ export function createIdResolver(
             idOnly: true,
           }),
         ],
+        undefined,
+        false,
       )
       pluginContainerMap.set(environment, pluginContainer)
     }
@@ -92,6 +94,8 @@ export function createIdResolver(
       pluginContainer = await createEnvironmentPluginContainer(
         environment as Environment,
         [aliasPlugin({ entries: environment.config.resolve.alias })],
+        undefined,
+        false,
       )
       aliasOnlyPluginContainerMap.set(environment, pluginContainer)
     }

diff --git a/packages/vite/src/node/optimizer/scan.ts b/packages/vite/src/node/optimizer/scan.ts
@@ -67,6 +67,8 @@ export class ScanEnvironment extends BaseEnvironment {
     this._pluginContainer = await createEnvironmentPluginContainer(
       this,
       this.plugins,
+      undefined,
+      false,
     )
   }
 }

diff --git a/packages/vite/src/node/server/pluginContainer.ts b/packages/vite/src/node/server/pluginContainer.ts
@@ -136,11 +136,13 @@ export async function createEnvironmentPluginContainer(
   environment: Environment,
   plugins: Plugin[],
   watcher?: FSWatcher,
+  autoStart = true,
 ): Promise<EnvironmentPluginContainer> {
   const container = new EnvironmentPluginContainer(
     environment,
     plugins,
     watcher,
+    autoStart,
   )
   await container.resolveRollupOptions()
   return container
@@ -183,7 +185,9 @@ class EnvironmentPluginContainer {
     public environment: Environment,
     public plugins: Plugin[],
     public watcher?: FSWatcher,
+    autoStart = true,
   ) {
+    this._started = !autoStart
     this.minimalContext = new MinimalPluginContext(
       { rollupVersion, watchMode: true },
       environment,
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,6 +67,8 @@ export class ScanEnvironment extends BaseEnvironment { @@
         this._pluginContainer = await createEnvironmentPluginContainer(
           this,
           this.plugins,
+          undefined,
+          false,
         )
       }
     }
@@ Expand Down @@