only on dev

vitejs · Aug 27, 2023 · 2a664d8 · 2a664d8
1 parent 8aeeab1
commit 2a664d8
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 10 deletions.
diff --git a/packages/vite/src/node/plugins/asset.ts b/packages/vite/src/node/plugins/asset.ts
@@ -190,7 +190,9 @@ export function assetPlugin(config: ResolvedConfig): Plugin {
 
       id = id.replace(urlRE, '$1').replace(unnededFinalQueryCharRE, '')
       const url = await fileToUrl(id, config, this)
-      return `export default ${JSON.stringify(`${url}?t=${Date.now()}`)}`
+      return `export default ${JSON.stringify(
+        config.command === 'serve' ? `${url}?t=${Date.now()}` : url,
+      )}`
     },
 
     renderChunk(code, chunk, opts) {

diff --git a/playground/assets/__tests__/assets.spec.ts b/playground/assets/__tests__/assets.spec.ts
@@ -260,7 +260,9 @@ describe('svg fragments', () => {
 
   test('from js import', async () => {
     const img = await page.$('.svg-frag-import')
-    expect(await img.getAttribute('src')).toMatch(/svg#icon-heart-view$/)
+    expect(await img.getAttribute('src')).toMatch(
+      isBuild ? /svg#icon-heart-view$/ : /svg\?t=\d+#icon-heart-view$/,
+    )
   })
 })
 
@@ -288,11 +290,11 @@ test('?url import', async () => {
 test('?url import on css', async () => {
   const src = readFile('css/icons.css')
   const txt = await page.textContent('.url-css')
-  expect(txt).toEqual(
-    isBuild
-      ? `data:text/css;base64,${Buffer.from(src).toString('base64')}`
-      : '/foo/css/icons.css',
-  )
+  isBuild
+    ? expect(txt).toEqual(
+        `data:text/css;base64,${Buffer.from(src).toString('base64')}`,
+      )
+    : expect(txt).toMatch(/^\/foo\/css\/icons.css\?t=\d+$/)
 })
 
 describe('unicode url', () => {

diff --git a/playground/assets/__tests__/relative-base/relative-base-assets.spec.ts b/playground/assets/__tests__/relative-base/relative-base-assets.spec.ts
@@ -183,7 +183,9 @@ describe('svg fragments', () => {
 
   test('from js import', async () => {
     const img = await page.$('.svg-frag-import')
-    expect(await img.getAttribute('src')).toMatch(/svg#icon-heart-view$/)
+    expect(await img.getAttribute('src')).toMatch(
+      isBuild ? /svg#icon-heart-view$/ : /svg\?t=\d+#icon-heart-view$/,
+    )
   })
 })
 

diff --git a/playground/assets/__tests__/runtime-base/runtime-base-assets.spec.ts b/playground/assets/__tests__/runtime-base/runtime-base-assets.spec.ts
@@ -179,7 +179,9 @@ describe('svg fragments', () => {
 
   test('from js import', async () => {
     const img = await page.$('.svg-frag-import')
-    expect(await img.getAttribute('src')).toMatch(/svg#icon-heart-view$/)
+    expect(await img.getAttribute('src')).toMatch(
+      isBuild ? /svg#icon-heart-view$/ : /svg\?t=\d+#icon-heart-view$/,
+    )
   })
 })
 

diff --git a/playground/assets/__tests__/url-base/url-base-assets.spec.ts b/playground/assets/__tests__/url-base/url-base-assets.spec.ts
@@ -175,7 +175,9 @@ describe('svg fragments', () => {
 
   test('from js import', async () => {
     const img = await page.$('.svg-frag-import')
-    expect(await img.getAttribute('src')).toMatch(/svg#icon-heart-view$/)
+    expect(await img.getAttribute('src')).toMatch(
+      isBuild ? /svg#icon-heart-view$/ : /svg\?t=\d+#icon-heart-view$/,
+    )
   })
 })