fix: delete execa std props #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
commented
Jun 12, 2024
Comment on lines
+55
to
+61
| } catch (error) { | ||
| // Since we already piped the io to the parent process, we remove the duplicated | ||
| // messages here so it's easier to read the error message. | ||
| if (error.stdout) error.stdout = 'value removed by vite-ecosystem-ci' | ||
| if (error.stderr) error.stderr = 'value removed by vite-ecosystem-ci' | ||
| if (error.stdio) error.stdio = ['value removed by vite-ecosystem-ci'] | ||
| throw error |
There was a problem hiding this comment.
It's also possible to check with error instanceof ExecaError, but for some reason the types are different, e.g. it marked error.stdout: undefined, which is not true.
dominikg
approved these changes
Jun 12, 2024
haoqunjiang
pushed a commit
to vuejs/ecosystem-ci
that referenced
this pull request
Jun 14, 2024
danielroe
pushed a commit
to nuxt/ecosystem-ci
that referenced
this pull request
Aug 13, 2024
lilpoozie2005
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/9476969819/job/26110768545
The execa std errors are hard to read, especially that we had already piped the output the the main process, so I don't think we need the props anymore.