Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateSettings and id #511

Closed
franiis opened this issue Feb 10, 2016 · 1 comment
Closed

UpdateSettings and id #511

franiis opened this issue Feb 10, 2016 · 1 comment

Comments

@franiis
Copy link

franiis commented Feb 10, 2016

Hi,
I think that UpdateSettings has similar bug to #509 (I don't know java very well, but I guess similar solution would be enough).

API method updateUserSetting require userSetting's id (because it use equals method which compares by mentioned id).

But id has @JsonIgnore attribute - so it won't be loaded to API method, and will throw AccessDaniedException.
As "id" of UserSetting is necessary to update UserSetting maybe just remove this attribute and allow API's users to obtain this ID.

Greetings
Piotr - franiis

PS. I deleted locally this attribute and it's working, but I think that it's worth reporting.

@vitalidze
Copy link
Owner

I think it should be safe to remove @JsonIgnore annotation from the id field. Previously there were no need to update it through the API.

Thanks for reporting.

P.S. you can submit a pull request with this change if it is possible.

franiis added a commit to franiis/traccar-web that referenced this issue Feb 11, 2016
allows to set getPositions flag via API
@franiis franiis mentioned this issue Feb 11, 2016
@franiis franiis closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants