This repository has been archived by the owner on Jun 18, 2023. It is now read-only.
Fix compilation error, warnings and migrate to 2018 edition #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this crate!
The crate wasn't compiling for me, so I've took the opportunity to fix the warnings. Note that after all those changes, the VPK size is still the same.
I made 4 commits:
overflowing_literals
lint for all editions rust-lang/rust#55632, the code was using repr(C) in enums which used values higher than isize::MAX (same as i32::MAX on vita), which is considered an overflow. Since C enums have no signedness guarantee, I only changed to repr(u32) those that would actually overflow.Copy
andClone
forSce
types, since they can be copied, are small and its how they're usually used in C. While at it, also derivedDebug
. I've removed#![feature(untagged_unions)]
since its no longer needed.I also needed to update to patch
rust-script
as it wasn't detecting thefn main()
in somecargo-make
scripts: fornwall/rust-script#18What do you think?