vis#4027: fix hover detection over nodes after hovering over an edge #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
changed the title
yotamberk
approved these changes
Jul 27, 2019
This was referenced Jul 27, 2019
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an original contribution from @Gelio: almende/vis#4027
This was also copies to visjs-netwoek:
visjs-community/visjs-network#29
this is an addition to #21
partially fixes #7
When the mouse enters a node while hovering over an edge previously, the node hover event is not emitted.
Here are the screenshots of this unintended behavior. I have marked the mouse position with a black dot.
This PR fixes that issue. It has been also mentioned in almende/vis#3907, which this PR also fixes.