Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding to set the "Content-Length" header for GET requests #1460

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Avoiding to set the "Content-Length" header for GET requests #1460

merged 4 commits into from
Apr 8, 2019

Conversation

marcellobarile
Copy link
Contributor

PR for #1459

@marcellobarile
Copy link
Contributor Author

marcellobarile commented Feb 15, 2019

tests on Travis seem to randomly fail. All tests pass on local.

@niftylettuce
Copy link
Collaborator

@marcellobarile I'd love to get this added to v5.x release which just came out. Do you think you could add it? You'll have to modify src/node/index.js instead of lib/node/index.js (see latest master branch).

@marcellobarile
Copy link
Contributor Author

sure, I'll do that. Thanks @niftylettuce

@marcellobarile
Copy link
Contributor Author

@niftylettuce seems that tests on travis are still randomly failing; I'm not sure if it's strictly related to this PR though. Do you have any clue?

@niftylettuce
Copy link
Collaborator

niftylettuce commented Apr 8, 2019

@marcellobarile I unfortunately had to revert this change.

Please see my comment here 804c35c#r33084161

The tests are failing due to your PR

@marcellobarile
Copy link
Contributor Author

yup, saw that. I will retouch it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants