Avoiding to set the "Content-Length" header for GET requests #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests on Travis seem to randomly fail. All tests pass on local. |
|
@marcellobarile I'd love to get this added to v5.x release which just came out. Do you think you could add it? You'll have to modify |
|
sure, I'll do that. Thanks @niftylettuce |
|
@niftylettuce seems that tests on travis are still randomly failing; I'm not sure if it's strictly related to this PR though. Do you have any clue? |
niftylettuce
added a commit
that referenced
this pull request
Apr 8, 2019
|
@marcellobarile I unfortunately had to revert this change. Please see my comment here 804c35c#r33084161 The tests are failing due to your PR |
|
yup, saw that. I will retouch it asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1459