Revert "Avoiding to set the "Content-Length" header for GET requests (#…

…1460)" (#1477)

This reverts commit 804c35c.

src/node/index.js

@@ -951,7 +951,6 @@ Request.prototype._end = function() {
   let data = this._data;
   const { req } = this;
   const { method } = this;
-  const methodsWithBody = ['PUT', 'POST', 'PATCH'];
 
   this._setTimeouts();
 
@@ -971,11 +970,7 @@ Request.prototype._end = function() {
     }
 
     // content-length
-    if (
-      methodsWithBody.includes(method) &&
-      data &&
-      !req.getHeader('Content-Length')
-    ) {
+    if (data && !req.getHeader('Content-Length')) {
       req.setHeader(
         'Content-Length',
         Buffer.isBuffer(data) ? data.length : Buffer.byteLength(data)

test/request.js

@@ -172,21 +172,6 @@ describe('request', function() {
     });
   });
 
-  it('GET should not send the content-length header', next => {
-    request
-      .get(`${uri}/content-length`)
-      .send({ foo: 'bar' })
-      .then(res => {
-        try {
-          assert(!res.badRequest);
-          next();
-        } catch (err) {
-          next(err);
-        }
-      })
-      .catch(next);
-  });
-
   it('get()', next => {
     request.get(`${uri}/notfound`).end((err, res) => {
       try {

test/support/server.js

@@ -578,17 +578,5 @@ app.get('/error/redirect-error:id', (req, res) => {
   }
 });
 
-app.get('/content-length', (req, res) => {
-  const { headers } = req;
-  if (
-    headers.hasOwnProperty('content-length') &&
-    headers['content-length'] > 0
-  ) {
-    res.status(400).send('bad request');
-  } else {
-    res.status(200).send('ok');
-  }
-});
-
 const server = http.createServer(app);
 server.listen(process.env.ZUUL_PORT);