rule: fix parsing zero priority rule #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jronak
force-pushed
the
fix/rule-prio
branch
2 times, most recently
from
24401a1 to
37131be
Compare
aboch
reviewed
Mar 28, 2024
aboch
reviewed
Mar 28, 2024
| @@ -222,6 +222,26 @@ func runRuleListFiltered(t *testing.T, family int, srcNet, dstNet *net.IPNet) { | |||
| return rs, false | |||
| }, | |||
| }, | |||
| { | |||
| name: "returns one rule filtered by Priority(0) and Table", | |||
| ruleFilter: &Rule{Priority: 0, Table: 1}, | |||
There was a problem hiding this comment.
In my opinion, we should also test the situation where the rule priority is not specified by us when we program the kernel. That happens when we client uses the NewRule() method, and Priority is set to -1.
There was a problem hiding this comment.
Updated tests to add rule with priority unset, which results into rule creation with priority preceding main table (32766).
|
Thanks. Please squash your two commits into one. |
|
Squashed commits into one, thanks! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #709 (see issue for repro)
This happens as the rule with priority=0 don't contain
nl.FRA_PRIORITYattribute, which leaves the priority in the struct as -1 which was set byNewRule.Wrote a test which fails before the fix: