fq: Fix to set missing TCA_FQ_PLIMIT attribute #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qdiscPayload() function was missing the TCA_FQ_PLIMIT attribute for the Fq Qdisc. Therefore, it could not be changed via the library. Fix this up, so that QdiscReplace() with different qdisc.PacketLimit works now. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
|
Hi 👋 @aboch, if you get a chance, please take a look. :) |
|
LGTM |
borkmann
added a commit
to cilium/cilium
that referenced
this pull request
Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support for setting TCA_FQ_PLIMIT and managing netkit driver (future work). Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: vishvananda/netlink#929 Link: vishvananda/netlink#930
borkmann
added a commit
to cilium/cilium
that referenced
this pull request
Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support for setting TCA_FQ_PLIMIT and managing netkit driver (future work). Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: vishvananda/netlink#929 Link: vishvananda/netlink#930
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 1, 2023
Pull in recent additions to the netlink go library, that is, support for setting TCA_FQ_PLIMIT and managing netkit driver (future work). Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: vishvananda/netlink#929 Link: vishvananda/netlink#930
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
Pull in recent additions to the netlink go library, that is, support for setting TCA_FQ_PLIMIT and managing netkit driver (future work). Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: vishvananda/netlink#929 Link: vishvananda/netlink#930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qdiscPayload() function was missing the TCA_FQ_PLIMIT attribute for the Fq Qdisc. Therefore, it could not be changed via the library. Fix this up, so that QdiscReplace() with different qdisc.PacketLimit works now.