fix: check for ext ACK TLVs #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking for Extended ACK in nlmsghdr flags should be done with bitwise AND op instead of OR op Signed-off-by: adrianc <adrianc@nvidia.com>
adrianchiris
commented
Nov 12, 2023
| // < code which needs to be executed in specific netns> | ||
| // } | ||
| // | ||
| // func jobAt(...) error { |
There was a problem hiding this comment.
this change is unrelated to the fix but the linter keeps adjusting the style.
|
Thanks for catching this one |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking for Extended ACK in nlmsghdr flags
should be done with bitwise AND op instead of OR op