Make xfrm linux-only #917
Merged
Make xfrm linux-only #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
approved these changes
Oct 5, 2023
|
The |
|
@aboch @vishvananda PTAL |
The xfrm framework is linux-only. Only implement the respective types for GOOS=linux to avoid dependencies to x/sys/unix on non-linux or non-unix platforms. Provide dummy XfrmPolicy and XfrmState types for the globally defined XfrmPolicy* and XfrmState* functions.
tklauser
force-pushed
the
xfrm-linux-only
branch
from
98f2fbe to
ee93f8e
Compare
|
Rebased to fix the test failures. |
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Oct 25, 2023
This pulls in a few fixes (namely vishvananda/netlink#917) which avoids building the netlink package on non-linux platforms, simplifying its use for cross-platform builds e.g. in cilium-cli which transitively (through cilium/cilium) vendors the netlink package. Signed-off-by: Tobias Klauser <tobias@cilium.io>
michi-covalent
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 25, 2023
This pulls in a few fixes (namely vishvananda/netlink#917) which avoids building the netlink package on non-linux platforms, simplifying its use for cross-platform builds e.g. in cilium-cli which transitively (through cilium/cilium) vendors the netlink package. Signed-off-by: Tobias Klauser <tobias@cilium.io>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Oct 27, 2023
This pulls in a few fixes (namely vishvananda/netlink#917) which avoids building the netlink package on non-linux platforms, simplifying its use for cross-platform builds e.g. in cilium-cli which transitively (through cilium/cilium) vendors the netlink package. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xfrm framework is linux-only. Only implement the respective types for GOOS=linux to avoid dependencies to x/sys/unix on non-linux or non-unix platforms. Provide dummy XfrmPolicy and XfrmState types for the globally defined XfrmPolicy* and XfrmState* functions.