Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IFF_MULTI_QUEUE from x/sys/unix to define TUNTAP_MULTI_QUEUE #330

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

tklauser
Copy link
Contributor

Use the constant defined in the golang.org/x/sys/unix package instead of
locally open-coding it.

Signed-off-by: Tobias Klauser tklauser@distanz.ch

Use the constant defined in the golang.org/x/sys/unix package instead of
locally open-coding it.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Copy link
Collaborator

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcrisciani fcrisciani merged commit 25d2c79 into vishvananda:master Feb 13, 2018
@tklauser tklauser deleted the tuntap-multiqueue-const branch February 13, 2018 16:34
@lzap
Copy link

lzap commented Jun 7, 2019

Does not compile on Fedora 30 golang which is go version go1.12.5 linux/amd64 for the record.

@tklauser
Copy link
Contributor Author

tklauser commented Jun 7, 2019

@lzap there's probably an outdated version of golang.org/x/sys/unix in your $GOPATH. Please update it to get the constants.

FWIW, I also sent #456 which adds a go.mod file which pins the required version of golang.org/x/sys/unix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants