Send IFA_CACHEINFO when setting up addresses #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements setting the cacheinfo attributes in addrHandle, to enable setting the valid_lft and preferred_lft values on addresses inserted. Currently, these values are ignored.
There is an interface issue because the default values for these fields in go are valid values for the netlink fields, but they are not very good default values. I have implemented what I think is a reasonable interface there, but I don't believe it is especially great. Any feedback on a better way to handle these parameters would be welcome.
This also removes the IFA_BROADCAST and IFA_LABEL fields from messages for non-ipv4 addresses, since these attributes are ignored for other kinds of addresses.