Add Matchall filter #311
Merged
Add Matchall filter #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. After that, if possible, please add a test in |
|
@aboch It appears updated. |
sargun
commented
Jan 2, 2018
| @@ -168,13 +168,13 @@ func TestAdvancedFilterAddDel(t *testing.T) { | |||
| } | |||
|
|
|||
| u32SelKeys := []TcU32Key{ | |||
| TcU32Key{ | |||
| { | |||
There was a problem hiding this comment.
These changes were made by gofmt, I can split it out into another PR, or a different commit
aboch
reviewed
Jan 3, 2018
filter_test.go
Outdated
| } | ||
|
|
||
| func TestFilterClsActBpfAddDel(t *testing.T) { | ||
| tearDown := setUpNetlinkTest(t) |
There was a problem hiding this comment.
I no longer have a 3.10 kernel VM at hand to check this, but I am assuming this test would fail on older kernel.
Can you please add the call
minKernelRequired(t, x, y)
at the beginning of this test function, and move the same call at line 572 to the top of the new test function.
Thanks
|
@aboch updated. |
aboch
reviewed
Jan 5, 2018
| tearDown := setUpNetlinkTest(t) | ||
| defer tearDown() | ||
| if err := LinkAdd(&Ifb{LinkAttrs{Name: "foo"}}); err != nil { | ||
| func setupLinkForTestWithQdisc(t *testing.T, linkName string) (Qdisc, Link) { |
|
Thanks @sargun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.