Two functions: one for adding bond slave, one for getting veth peer index #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboch
reviewed
Dec 1, 2017
ioctl_linux.go
Outdated
| // IfreqSlave is a struct for ioctl bond manipulation syscalls. | ||
| // It is used to assign slave to bond interface with Name. | ||
| type IfreqSlave struct { | ||
| Name [syscall.IFNAMSIZ]byte |
There was a problem hiding this comment.
Can you switch to the unix pkg instead of syscall ?
aboch
reviewed
Dec 1, 2017
link_linux.go
Outdated
| func VethPeerIndex(link *Veth) (int, error) { | ||
| fd, err := getSocketUDP() | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
why not returning -1 as in all other error cases below
|
Thanks for the contributions. Couple of minor comments. Also, ideally this should be two commits: One for |
|
Thanks @aboch for review. I have fixed the two files you requested :) |
|
Please do not add a new commit to take care of the review comments. |
jjastrze-ovh
force-pushed
the
AddBondSlave
branch
from
89843bb to
320750e
Compare
|
@aboch I have put everything into one commit. |
|
Thanks @jjastrze-ovh / @phob0s-pl LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in topic. Please review this.