Allow index specification at link creation time #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2017
vishvananda
reviewed
Oct 20, 2017
link_linux.go
Outdated
| @@ -851,6 +851,14 @@ func (h *Handle) linkModify(link Link, flags int) error { | |||
| msg.Change |= syscall.IFF_MULTICAST | |||
| msg.Flags |= syscall.IFF_MULTICAST | |||
| } | |||
| if base.Index != 0 { | |||
| if flags&syscall.NLM_F_CREATE == 0 { | |||
There was a problem hiding this comment.
I don't think it should check for NLM_F_CREATE and error here. Specifically this will break BridgeSetMcastSnoop if you attempt to retrieve the link (which sets the index value) and then use the retrieved link to set snoop.
There was a problem hiding this comment.
Let me remove that check. I was just being paranoid. I did not realize that there was a case beyond create where it was valid to set the index.
Allow the caller to specify the desired link index at link creation. This is equivalent to ip link add link eth0 name testmacvtap index 1000 type macvtap ip link add dummy1 index 1001 type dummy Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
mcastelino
force-pushed
the
topic/create_with_index
branch
from
648aac8 to
35e0334
Compare
|
@vishvananda addressed the review comment. CI has also passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the caller to specify the desired link index at link creation.
This is equivalent to
ip link add link eth0 name testmacvtap index 1000 type macvtap
ip link add dummy1 index 1001 type dummy
Signed-off-by: Manohar Castelino manohar.r.castelino@intel.com