Retrieve VLAN ID when listing neighbour #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. I generally try to use int for values in the netlink library and convert back and forth when parsing. Would you mind switching vlan to an int? |
lebauce
force-pushed
the
vlan-neighbor
branch
from
f4c2468 to
59dc463
Compare
|
@vishvananda Sorry, I completely missed the notification. I rebased, added VNI and addressed your remark |
|
@lebauce Please rebase |
|
@lebauce Please rebase |
lebauce
force-pushed
the
vlan-neighbor
branch
from
59dc463 to
a3c50e1
Compare
|
@aboch Done |
|
Thank @lebauce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.