Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC FLOWER enrich match field and action about vlan #1045

Merged
merged 1 commit into from
Jan 16, 2025
Merged

TC FLOWER enrich match field and action about vlan #1045

merged 1 commit into from
Jan 16, 2025

Conversation

wangling94
Copy link
Contributor

  1. filter match support vlanId and srcMac, dstMac.
  2. filter action support vlan pop/push.

@wangling94
Copy link
Contributor Author

refer commit of shuowang123, but fix some problem like when show a flower with vlan match, filter.EthType is missing. test on our own service.
#809
#810

@wangling94
Copy link
Contributor Author

make sure the addition of rules could be queried exactly the same, add UT.

@wangling94 @wangling142
1. filter match support vlanId and srcMac, dstMac.
f942bf9 
2. filter action support vlan pop/push.
@wangling94
Copy link
Contributor Author

@aboch Excuse me, do you have time to take a look at this change? i have added corresponding UT to it.

@aboch
Copy link
Collaborator

aboch commented Jan 16, 2025

LGTM

@aboch aboch merged commit 68cf136 into vishvananda:main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangling94 @aboch