Fix SetSendTimeout/SetReceiveTimeout #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmry
force-pushed
the
fixes_for_nonblocking_sockets
branch
2 times, most recently
from
42fff99 to
592a422
Compare
corhere
reviewed
Aug 30, 2024
corhere
reviewed
Aug 30, 2024
robmry
force-pushed
the
fixes_for_nonblocking_sockets
branch
from
592a422 to
93162b8
Compare
robmry
force-pushed
the
fixes_for_nonblocking_sockets
branch
from
93162b8 to
3c3e5c7
Compare
They were implemented using SO_SNDTIMEO/SO_RCVTIMEO on the socket descriptor - but that doesn't work now the socket is non-blocking. Instead, set deadlines on the file read/write. Signed-off-by: Rob Murray <rob.murray@docker.com>
robmry
force-pushed
the
fixes_for_nonblocking_sockets
branch
from
3c3e5c7 to
6e8c519
Compare
|
I'm not sure who needs to review this ... @aboch, could you take a look? |
This was referenced Sep 12, 2024
robmry
added a commit
to robmry/moby
that referenced
this pull request
Oct 7, 2024
…93d350 - Preserve results when NLM_F_DUMP_INTR is set vishvananda/netlink#1018 - Fix SetSendTimeout/SetReceiveTimeout vishvananda/netlink#1012 full diff: vishvananda/netlink@v1.3.0...084abd9 Signed-off-by: Rob Murray <rob.murray@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #793, netlink sockets were blocking.
Send/receive timeouts were implemented using
SO_SNDTIMEO/SO_RCVTIMEOon the socket descriptor. But, that doesn't work now the socket is non-blocking.Instead, set deadlines on the file read/write.