add tests for save and load filters

vish9812 · Nov 29, 2024 · e99c8e5 · e99c8e5
1 parent a7c2511
commit e99c8e5
Show file tree

Hide file tree

Showing 3 changed files with 106 additions and 12 deletions.
diff --git a/ui/src/components/filters/useViewModel.test.tsx b/ui/src/components/filters/useViewModel.test.tsx
@@ -1,5 +1,10 @@
 import { createRoot } from "solid-js";
-import useViewModel, { GridsRefs, defaultFilters } from "./useViewModel";
+import useViewModel, {
+  FiltersData,
+  GridsRefs,
+  defaultFilters,
+  savedFilterKeyName,
+} from "./useViewModel";
 import { FiltersProps } from "./useViewModel";
 import comparer from "@al/services/comparer";
 import LogData, { Summary } from "@al/models/logData";
@@ -89,13 +94,14 @@ describe("useViewModel", () => {
   });
 
   afterEach(() => {
-    vi.restoreAllMocks();
+    vi.clearAllMocks();
   });
 
   test("initial values", () => {
     createRoot((dispose) => {
       const vm = useViewModel(null as any);
 
+      expect(vm.savedFilterName(), "savedFilterName").toEqual("");
       expect(vm.addedLogs(), "addedLogs").toEqual(comparer.added);
       expect(vm.removedLogs(), "removedLogs").toEqual(comparer.removed);
       expect(vm.unchangedLogs(), "unchangedLogs").toEqual(comparer.unchanged);
@@ -111,6 +117,99 @@ describe("useViewModel", () => {
     });
   });
 
+  describe("manageSavedFilters", () => {
+    const filterName = "test_filter";
+
+    const filterToSave: FiltersData = {
+      startTime: "2023-10-20T01:00:00.000Z",
+      endTime: "2023-10-20T11:00:00.000Z",
+      errorsOnly: true,
+      logs: [
+        {
+          some_key: "some_value",
+        },
+      ],
+      regex: "^some.*regex$",
+      terms: [
+        {
+          and: true,
+          contains: true,
+          field: "some_field",
+          value: "ands",
+        },
+      ],
+      firstN: 1,
+      lastN: 1,
+    };
+
+    const expectedSavedFilter = { ...filterToSave, logs: [] };
+
+    beforeEach(() => {
+      localStorage.clear();
+    });
+
+    test("handleSaveFilter", () => {
+      createRoot((dispose) => {
+        const vm = useViewModel(props);
+
+        vm.setFilters(filterToSave);
+        vm.setSavedFilterName(filterName);
+        vm.handleSaveFilter();
+
+        expect(vm.savedFilterName(), "savedFilterName").toEqual(filterName);
+        expect(localStorage.length, "localStorage.length").toEqual(1);
+        const loadedFilterStr = localStorage.getItem(
+          savedFilterKeyName(filterName)
+        );
+        expect(loadedFilterStr, "loadedFilterStr").toBeTruthy();
+        const loadedFilterJSON = JSON.parse(loadedFilterStr!);
+        expect(loadedFilterJSON, "loadedFilterJSON").toEqual(
+          expectedSavedFilter
+        );
+
+        dispose();
+      });
+    });
+
+    describe("handleLoadFilter", () => {
+      test("whenNoFilterIsAvailableToLoad", () => {
+        createRoot((dispose) => {
+          const vm = useViewModel(props);
+
+          vm.handleLoadFilter(filterName);
+
+          expect(vm.savedFilterName(), "savedFilterName").toEqual(filterName);
+          expect(vm.filters, "filters").toEqual(defaultFilters());
+          expect(props.onFiltersChange, "onFiltersChange").toBeCalledWith(
+            vm.filters
+          );
+
+          dispose();
+        });
+      });
+
+      test("whenAFilterIsAvailableToLoad", () => {
+        createRoot((dispose) => {
+          const vm = useViewModel(props);
+
+          localStorage.setItem(
+            savedFilterKeyName(filterName),
+            JSON.stringify(expectedSavedFilter)
+          );
+          vm.handleLoadFilter(filterName);
+
+          expect(vm.savedFilterName(), "savedFilterName").toEqual(filterName);
+          expect(vm.filters, "filters").toEqual(expectedSavedFilter);
+          expect(props.onFiltersChange, "onFiltersChange").toBeCalledWith(
+            vm.filters
+          );
+
+          dispose();
+        });
+      });
+    });
+  });
+
   test("handleFiltersChange", () => {
     createRoot((dispose) => {
       const vm = useViewModel(props);
@@ -248,7 +347,7 @@ describe("useViewModel", () => {
         unchanged: {
           api: {
             getSelectedRows: () => [
-              { logs: [{ id: 2 }, {id: 11}, { id: 4 }] },
+              { logs: [{ id: 2 }, { id: 11 }, { id: 4 }] },
               { logs: [{ id: 5 }] },
             ],
           },
@@ -302,7 +401,9 @@ describe("useViewModel", () => {
         expect(vm.filters.errorsOnly, "errorsOnly").toEqual(checked);
         expect(vm.addedLogs(), "addedLogs").toEqual(errAddedTopLogs);
         expect(vm.removedLogs(), "removedLogs").toEqual(errRemovedTopLogs);
-        expect(vm.unchangedLogs(), "unchangedLogs").toEqual(errUnchangedTopLogs);
+        expect(vm.unchangedLogs(), "unchangedLogs").toEqual(
+          errUnchangedTopLogs
+        );
         expect(vm.msgs(), "msgs").toEqual(errMsgs);
         expect(vm.httpCodes(), "httpCodes").toEqual(errHTTPCodes);
         expect(vm.jobs(), "jobs").toEqual(errJobs);

diff --git a/ui/src/components/filters/useViewModel.tsx b/ui/src/components/filters/useViewModel.tsx
@@ -78,10 +78,6 @@ function deleteAllSavedFilters(): void {
   savedFilterKeys().forEach((key) => localStorage.removeItem(key));
 }
 
-function deleteSavedFilter(filterName: string) {
-  localStorage.removeItem(savedFilterKeyName(filterName));
-}
-
 function useViewModel(props: FiltersProps) {
   const [savedFilterName, setSavedFilterName] = createSignal("");
   const [filters, setFilters] = createStore(defaultFilters());
@@ -235,5 +231,5 @@ function useViewModel(props: FiltersProps) {
 }
 
 export default useViewModel;
-export { defaultFilters, savedFilterKeys };
+export { defaultFilters, savedFilterKeys, savedFilterKeyName };
 export type { SearchTerm, FiltersData, FiltersProps, GridsRefs };
diff --git a/ui/src/pages/analyze/useViewModel.tsx b/ui/src/pages/analyze/useViewModel.tsx
@@ -90,9 +90,6 @@ function useViewModel() {
           updateCurrCondition(term);
         }
 
-        if (!currCondition) {
-        }
-
         keep = currCondition;
       }
-Original file line number
+Diff line change
@@ Expand Up / @@ -90,9 +90,6 @@ function useViewModel() { @@
               updateCurrCondition(term);
             }
-            if (!currCondition) {
-            }
             keep = currCondition;
           }
@@ Expand Down @@