Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export native types where possible #2263

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Re-export native types where possible #2263

merged 5 commits into from
Aug 24, 2023

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Aug 21, 2023

  • Re-export native types wherever possible (LngLat, Point, etc.)
  • Match v7.0 type names
  • Update docs:
    • Link to both Mapbox and Maplibre
    • Update outdated types page

@tordans
Copy link
Contributor

tordans commented Aug 25, 2023

@Pessimistress In my PR at https://github.com/visgl/react-map-gl/pull/2238/files#diff-3ef10b940781cab3ed12f5be2c34e7ad5128e654b92569f1c073cbc289c17eb1 I had links to both mapbox and maplibre docs. Your version still only has mapbox.
Are you open to adding the maplibre docs as well in the way I did in eg in https://github.com/visgl/react-map-gl/pull/2238/files#diff-3ef10b940781cab3ed12f5be2c34e7ad5128e654b92569f1c073cbc289c17eb1L13-R17 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants