Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reuseMaps actions wrong expectations #2092

Merged

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented Dec 29, 2022

In this PR I have solved issue #2071
I've tried and created a temporary release in the meantime, you can check out the results here, this forked from issue report.

Please review and review it, many thanks. ^^

cc @Pessimistress @theRuslan

@Pessimistress
Copy link
Collaborator

Thanks for the proposal. cloneElement could be quite expensive if there are a lot of child elements. Can you try wrapping all children in a single div and removing that div upon dismount?

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jan 2, 2023

I updated it according to what you said above.
I tried using react's ref but it didn't give the desired effect because the mechanism will go after we save the value, you can see more here 2e4df06.

cc @Pessimistress

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jan 2, 2023

Please review and release it soon if possible, I'm really waiting for it. Thank you ^^.

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jan 6, 2023

Hmmmmm, If there is a problem please leave me a message. @Pessimistress @theRuslan

@Pessimistress
Copy link
Collaborator

Can you run yarn lint fix?

@lh0x00
Copy link
Contributor Author

lh0x00 commented Jan 7, 2023

@Pessimistress it's ready to merge

@Pessimistress Pessimistress merged commit 9baded6 into visgl:master Jan 7, 2023
@lh0x00 lh0x00 deleted the bugfix/ReuseMapsWrongExpectations branch January 8, 2023 02:46
@lh0x00 lh0x00 restored the bugfix/ReuseMapsWrongExpectations branch January 8, 2023 02:50
@lh0x00 lh0x00 deleted the bugfix/ReuseMapsWrongExpectations branch January 8, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants