GPU Aggregation: miscellaneous clean up #9142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/aggregation-misc
branch
from
3fe0fd7
to
88bde1b
Compare
felixpalmer
approved these changes
Sep 5, 2024
| @@ -0,0 +1,30 @@ | |||
| /** Utility to estimate binIdRange as expected by AggregatorProps */ | |||
| export function getBinIdRange({ | |||
There was a problem hiding this comment.
Why is it only an estimate?
Suggested change
| export function getBinIdRange({ | |
| export function estimateBinIdRange({ |
| @@ -0,0 +1,30 @@ | |||
| /** Utility to estimate binIdRange as expected by AggregatorProps */ | |||
| export function getBinIdRange({ | |||
There was a problem hiding this comment.
Export this function for use in custom layers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List
getBinIdRangeutilcolorRangebehavior with the other layers