Lobby rework #844
Merged
Lobby rework #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full rewrite of the lobby room in order to transition from a mono-lobby to multiple lobby instances that act as a waiting room for each potential game room with considerably more player control than before relies more on the room state than before + other steps to make the room code more readable
- uses vuex store instead of mutating component properties - replaces the blank screen with an index of active lobby rooms and buttons for joining, creating rooms, etc. - adds a child route to lobby (/lobby/room/[roomId]) that lists clients connected to the room with further action buttons, a local chat, etc. allows for inviting by sharing the room url
- move message alerts and other dashboard items to the lobby index page - this removes any way to view previous game stats but this will eventually be included in the leaderboard TODO: rename or remove remaining dashboard related things, or alternatively: rename top lobby view to dashboard TODO: remove or reconcile schedule with new lobby setup somehow
- scheduling service still exists but is disabled until a use is determined for it - use of the game schedule on the client was removed - dashboard service/routes and client-side dashboard components removed or split into logical components for current or future use. specifically, player stats were moved to a leaderboard service and (currently unused) code dealing with surveys was given a survey service
alee
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lobby has been rewritten to be a 5 person room that acts a waiting room for individual games. Includes a local room chat, options to start games with bots, etc. Of course gets a bump in readability/maintainability
On the client, a lobby index view and room view replace the dashboard and old lobby
TODO: