Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Without Attempting To Keep Origins Permissions #1412

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

AvocadoMoon
Copy link
Contributor

@AvocadoMoon AvocadoMoon commented Jan 9, 2025

Instead of using the flag which attempts to keep source file permissions, let them be whatever the target file permissions are, updating the target files time stamp in the process.

@AvocadoMoon AvocadoMoon requested a review from jcschaff January 9, 2025 14:44
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the benefit of this change, and seems low risk - approved.

@AvocadoMoon AvocadoMoon merged commit 654e1cb into master Jan 9, 2025
14 checks passed
@AvocadoMoon AvocadoMoon deleted the help-generation-fix branch January 9, 2025 14:55
@AvocadoMoon AvocadoMoon linked an issue Jan 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VCell HTML help has dead links
2 participants