Skip to content

Commit

Permalink
Merge pull request #231 from Vanshika-Dhingra/bug-fix-branch
Browse files Browse the repository at this point in the history
Made lab-display-name an optional parameter
  • Loading branch information
raj-vlabs authored Sep 9, 2023
2 parents 343a854 + 40dc26d commit bbd6aa6
Show file tree
Hide file tree
Showing 5 changed files with 87 additions and 4 deletions.
5 changes: 3 additions & 2 deletions lab_build/exp_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ function exp_clone(e, exp_dir) {
shell.mkdir("-p", path.resolve(exp_dir));
shell.rm("-rf", path.resolve(exp_dir, e_short_name));
shell.exec(
`git clone -b ${e.tag} --depth 1 ${e.repo} ${path.resolve(
`git clone -b ${e.tag} --depth 1 ${e.repo} "${path.resolve(
exp_dir,
e_short_name
)}`
)}"`,
{silent: false}
);
}

Expand Down
2 changes: 2 additions & 0 deletions lab_build/lab_gen.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ function moveToDeployDir(labpath) {
const elist = expList(require(path.resolve(labpath, "lab-descriptor.json")));

elist.forEach((e) => {
if (e.deploy) {
log.debug(`Deploying experiment ${e["short-name"]} to ${path.resolve(deployment_path, "exp", e["short-name"])}`);
shell.mkdir("-p", path.resolve(deployment_path, "exp", e["short-name"]));
// shell.exec(`rsync -arv --exclude .git \
Expand All @@ -78,6 +79,7 @@ function moveToDeployDir(labpath) {
`${deployment_path}/stage/exp/${e["short-name"]}/*`,
`${deployment_path}/exp/${e["short-name"]}`
);
}
});

// console.log(chalk`{bold DEPLOY LAB} to ${deployment_dest}/${lab_dir_name}`);
Expand Down
76 changes: 76 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"rsync": "^0.6.1",
"shelljs": "^0.8.4",
"simple-git": "^2.31.0",
"vlabs-buildexp": "^3.1.6",
"winston": "^3.8.2",
"yargs": "^17.0.1"
},
Expand Down
7 changes: 5 additions & 2 deletions validation/schemas/labDescSchema.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
{
"$schema": "http://json-schema.org/schema#",
"type": "object",
"required": ["lab", "lab_display_name", "broadArea", "phase", "collegeName",
"required": ["lab", "broadArea", "phase", "collegeName",
"baseUrl", "introduction", "objective",
"targetAudience", "courseAlignment"],
"properties": {
"lab": {"type": "string"},
"lab_display_name": {"type": "string"},
"lab_display_name": {
"type": "string",
"default": "Default Lab Display Name"
},
"broadArea": {
"type": "object",
"properties": {
Expand Down

0 comments on commit bbd6aa6

Please sign in to comment.