Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: UT for ExtensionPodStatsToKubeletPodStats with bugfix #534

Merged
merged 4 commits into from
Apr 13, 2023
Merged

test: UT for ExtensionPodStatsToKubeletPodStats with bugfix #534

merged 4 commits into from
Apr 13, 2023

Conversation

nidhunge
Copy link
Contributor

Issue Link: #514

@nidhunge nidhunge temporarily deployed to test April 13, 2023 19:01 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 13, 2023 19:01 — with GitHub Actions Inactive
@nidhunge nidhunge mentioned this pull request Apr 13, 2023
Closed
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #534 (ee619a0) into master (4856775) will increase coverage by 2.46%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   62.05%   64.52%   +2.46%     
==========================================
  Files          15       15              
  Lines        2485     2486       +1     
==========================================
+ Hits         1542     1604      +62     
+ Misses        828      767      -61     
  Partials      115      115
Impacted Files Coverage Δ
pkg/metrics/real_time.go 75.43% <100.00%> (+36.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nidhunge nidhunge temporarily deployed to test April 13, 2023 22:48 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 13, 2023 22:48 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 13, 2023 22:50 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 13, 2023 22:50 — with GitHub Actions Inactive
@nidhunge nidhunge requested a review from helayoty April 13, 2023 23:04
helayoty
helayoty approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@nidhunge nidhunge enabled auto-merge (squash) April 13, 2023 23:07
@nidhunge nidhunge merged commit edd1c9b into virtual-kubelet:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helayoty helayoty helayoty approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nidhunge @codecov-commenter @helayoty